Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation for empty registerBeanDefinitions() method [DATACMNS-1770] #2185

Closed
spring-projects-issues opened this issue Jul 21, 2020 · 3 comments
Closed

Add implementation for empty registerBeanDefinitions() method [DATACMNS-1770] #2185

spring-projects-issues opened this issue Jul 21, 2020 · 3 comments
Assignees
@mp911de
Labels
status: invalid An issue that we don't feel is valid

Comments

@spring-projects-issues
Copy link

Dave Syer opened DATACMNS-1770 and commented

AbstractRepositoryConfigurationSourceSupport overrides one of the registerBeanDefinitions() method in ImportBeanDefinitionRegistrar but not the other. The other one has an empty default implementation, so if anyone calls it, nothing happens. It would be helpful to add an implementation, even if it just throws an exception (hopefully it wouldn't need to)

No further details from DATACMNS-1770
@spring-projects-issues
Copy link
Author

Mark Paluch commented

AbstractRepositoryConfigurationSourceSupport is a Spring Boot class. Spring Data's RepositoryBeanDefinitionRegistrarSupport override both registerBeanDefinitions methods

@spring-projects-issues
Copy link
Author

Dave Syer commented

spring-projects/spring-boot#22480

@spring-projects-issues
Copy link
Author

Mark Paluch commented

Closing this ticket in favor of the Spring Boot ticket

@spring-projects-issues spring-projects-issues added the status: invalid An issue that we don't feel is valid label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mp911de @spring-projects-issues