Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #1960

Open
philwebb opened this issue Jan 21, 2021 · 2 comments
Open

Add integration tests #1960

philwebb opened this issue Jan 21, 2021 · 2 comments
Labels
status: feedback-provided Feedback has been provided

Comments

@philwebb
Copy link
Member

Unless I'm missed them, it looks like there currently aren't any integration tests for Spring Data Rest. Whilst looking at #1959 I couldn't find anywhere to add a test that replicated the problem before attempting to fix it. I needed to run the Spring Boot integration test instead, which adds some time to the process.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 21, 2021
@odrotbohm
Copy link
Member

There's an extensive set using all supported Spring Data stores in spring-data-rest-tests. Running the build with the it profile enabled runs those.

@odrotbohm odrotbohm added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 28, 2021
@philwebb
Copy link
Member Author

I missed those. I tried some things that I expected to fail but I wasn't aware of the it profile so they didn't. Perhaps this issue could be a documentation update to the CONTRIBUTING instructions?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: feedback-provided Feedback has been provided
Projects
None yet
Development

No branches or pull requests

3 participants