Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md missing word in commit message formatting description #22890

Closed
rewolf opened this issue May 5, 2019 · 1 comment
Closed

CONTRIBUTING.md missing word in commit message formatting description #22890

rewolf opened this issue May 5, 2019 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@rewolf
Copy link
Contributor

rewolf commented May 5, 2019

Format commit messages using 55 characters for the subject line, 72 lines for the description, followed by the issue fixed, e.g. Fixes #22276.

"72 lines" should read 72-character lines to explain that lines in the description should not exceed 72 characters in width.
@rewolf rewolf mentioned this issue May 5, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 5, 2019
@snicoll
Copy link
Member

snicoll commented May 5, 2019

@rewolf thank you for the report. FTR, there is no need to create both an issue and a PR as one supersedes the other.

Closing in favour of PR #22891

@snicoll snicoll closed this as completed May 5, 2019
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Polish CONTRIBUTING.md
3 participants
@rewolf @snicoll @spring-projects-issues