Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOP pointcut erroneously matching ProceedingJoinPoint.proceed when called from within another advised bean #26068

Closed
moxaj opened this issue Nov 11, 2020 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Milestone

Comments

@moxaj
Copy link

moxaj commented Nov 11, 2020

Affects: Spring Boot 2.3.5.RELEASE

There appears to be a bug in spring aop - see this stackoverflow issue, and my MCVE.

TLDR: when in an around advice, if I pass joinPoint::proceed (where joinPoint is the injected ProceedingJoinPoint) as a lambda or a method reference into another method (foo) of another class (Bar), an advice with a pointcut matching Bar::foo intercepts joinPoint.proceed() (NOT Bar::foo).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 11, 2020
@moxaj moxaj changed the title AOP pointcut matching ProceedingJoinPoint.proceed AOP pointcut matching ProceedingJoinPoint.proceed when it is passed as a lambda / method reference Nov 11, 2020
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 10, 2021
@jhoeller jhoeller added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 9, 2024
@jhoeller jhoeller self-assigned this Jan 9, 2024
@jhoeller jhoeller added this to the 6.1.3 milestone Jan 9, 2024
@jhoeller jhoeller changed the title AOP pointcut matching ProceedingJoinPoint.proceed when it is passed as a lambda / method reference AOP pointcut erroneously matching ProceedingJoinPoint.proceed when called from within another advised bean Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

4 participants