Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop defining a TaskScheduler bean in WebSocketConfigurationSupport #27903

Closed
wilkinsona opened this issue Jan 7, 2022 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

Affects: 5.3.x

WebSocketConfigurationSupport defines a TaskScheduler bean which causes problems in Boot as using @EnableWebSocket causes auto-configuration of a ThreadPoolTaskScheduler to back off, for example. My feeling is that this a very general contract for something that's more specific and largely an implementation detail. It would be helpful to Boot if Framework's WebSocket support could avoid defining a bean at all for its task scheduler or could use a different, WebSocket-specific type to do so.

While this affects 5.3.x, we think it may be a change that can't be made till 6.0.

@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement labels Jan 7, 2022
@rstoyanchev rstoyanchev self-assigned this Jan 10, 2022
@rstoyanchev rstoyanchev removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 10, 2022
@rstoyanchev rstoyanchev added this to the 6.0.0-M2 milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants