Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceHandlers cannot resolve static resources with certain wildcard patterns #29716

Closed
github-actions bot opened this issue Dec 19, 2022 · 0 comments
Closed

ResourceHandlers cannot resolve static resources with certain wildcard patterns #29716

github-actions bot opened this issue Dec 19, 2022 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
5.3.25

Comments

@github-actions
Copy link

Backport of gh-29712
@github-actions github-actions bot added in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Dec 19, 2022
@github-actions github-actions bot added this to the 5.3.25 milestone Dec 19, 2022
@bclozel bclozel self-assigned this Dec 19, 2022
bclozel added a commit that referenced this issue Dec 19, 2022
@bclozel
Fix path within mapping when pattern contains ".*"
777f01d 
Prior to this commit, extracting the path within handler mapping would
result in "" if the matching path element would be a Regex and contain
".*". This could cause issues with resource handling if the handler
mapping pattern was similar to `"/folder/file.*.extension"`.

This commit introduces a new `isLiteral()` method in the `PathElement`
abstract class that expresses whether the path element can be compared
as a String for path matching or if it requires a more elaborate
matching process.

Using this method for extracting the path within handler mapping avoids
relying on wildcard count or other properties.

See gh-29712
Fixes gh-29716
@bclozel bclozel closed this as completed Dec 19, 2022
@sbrannen sbrannen changed the title ResourceHandlers wont resolve static Wildcard Resources ResourceHandlers cannot resolve static resources with certain wildcard patterns Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
5.3.25
Development

No branches or pull requests
1 participant
@bclozel