Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that @Sql requires spring-jdbc and spring-tx on the classpath #30280

Closed
manueljordan opened this issue Apr 4, 2023 · 3 comments
Closed
Assignees
Labels
in: test Issues in the test module type: documentation A documentation task
Milestone

Comments

@manueljordan
Copy link

manueljordan commented Apr 4, 2023

The current documentation - through javadoc and reference documentation - has an interesting situation regarding @Sql behavior: it needs the spring-jdbc and spring-tx modules in the classpath. Otherwise, @Sql is completely ignored.

I noticed this when I had invalid paths referring to .sql files.

For more details, please read the following post on SO.

Thanks for your understanding

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 4, 2023
@sbrannen sbrannen added in: test Issues in the test module type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 4, 2023
@sbrannen sbrannen added this to the 6.0.x milestone Apr 4, 2023
@sbrannen sbrannen changed the title Indicate @Sql annotation needs in the classpath spring-jdbc and spring-tx Document that @Sql requires spring-jdbc and spring-tx on the classpath Apr 4, 2023
@sbrannen sbrannen modified the milestones: 6.0.x, 6.0.11 Jun 16, 2023
@manueljordan
Copy link
Author

@sbrannen thanks for the improvement, just a friendly observation, in the two files edited, appears twice the ... requires that that the ... part, where exists a problem: the that that appears twice.

As indicated, I confirmed that dependencies spring-jdbc and spring-tx are mandatory. Where the latter is a transitive dependency of the former. Of course to avoid confusions, is nice declare explicitly both

sbrannen added a commit that referenced this issue Jun 17, 2023
@sbrannen
Copy link
Member

Thanks for the feedback, @manueljordan. 👍

I pushed a polishing commit: 8bb4c16.

@manueljordan
Copy link
Author

manueljordan commented Jun 17, 2023

@sbrannen Just in case ... about the following part that appears twice

requires the {@code spring-jdbc} and {@code spring-tx} modules as well as their transitive dependencies to be present on the classpath

should be

requires the {@code spring-jdbc} and {@code spring-tx} modules to be present on the classpath

I wrote just as observation to be not included that spring-tx is a transitive dependency of spring-jdbc

mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

3 participants