Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a method in MockHttpServletRequestBuilder to set remote address #30510

Closed
leewin12 opened this issue May 21, 2023 · 3 comments
Closed

Introduce a method in MockHttpServletRequestBuilder to set remote address #30510

leewin12 opened this issue May 21, 2023 · 3 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@leewin12
Copy link
Contributor

leewin12 commented May 21, 2023 •
edited

Dear @sbrannen
I'd like to suggest the consideration of backporting gh-30497.
Given that Spring Boot 2.x heavily relies on 5.x, this backport could greatly benefit many users.

As always, thank you for your continued dedication and hard work on this project.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 21, 2023
@sbrannen sbrannen added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels May 23, 2023
@sbrannen
Copy link
Member

Thanks for raising the issue. We'll take it into consideration.

Please note, however, that there is no need to mention a specific person when creating an issue: the team collectively reviews new issues.

As always, thank you for your continued dedication and hard work on this project.

You're welcome!

@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label May 23, 2023
@sbrannen sbrannen self-assigned this May 23, 2023
@sbrannen sbrannen added the type: backport An issue that is a backport of another issue to a maintenance branch label May 23, 2023
@sbrannen sbrannen added this to the 6.0.10 milestone May 23, 2023
@sbrannen
Copy link
Member

We have decided to backport gh-30497 to 6.0.x.

Users of previous versions of the framework may choose to use the suggested workaround outlined in #30484 (comment).

@sbrannen sbrannen changed the title Backport Consideration about a method in MockHttpServletRequestBuilder to set remote address Introduce a method in MockHttpServletRequestBuilder to set remote address May 23, 2023
@sbrannen
Copy link
Member

Closing in favor of applying gh-30497 to the 6.0.x branch for inclusion in 6.0.10.

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
@sbrannen sbrannen added status: duplicate A duplicate of another issue and removed type: backport An issue that is a backport of another issue to a maintenance branch labels May 23, 2023
@sbrannen sbrannen removed this from the 6.0.10 milestone May 23, 2023
sbrannen pushed a commit that referenced this issue May 23, 2023
@leewin12 @sbrannen
Introduce method in MockHttpServletRequestBuilder to set remote address
fa85657 
Co-authored-by: Sam Brannen <sam@sambrannen.com>
See gh-30510
Closes gh-30497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbrannen @leewin12 @spring-projects-issues