Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use MethodArgumentNotValidException(MethodParameter, BindingResult) constructor #30558

Closed
sdeleuze opened this issue May 30, 2023 · 0 comments
Closed

Always use MethodArgumentNotValidException(MethodParameter, BindingResult) constructor #30558

sdeleuze opened this issue May 30, 2023 · 0 comments
Assignees
@sdeleuze
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.0.10

Comments

@sdeleuze
Copy link
Contributor

#23846 introduced a new MethodArgumentNotValidException(Executable, BindingResult) constructor that can be advantageously replaced by using MethodArgumentNotValidException(MethodParameter, BindingResult) in ModelAttributeMethodProcessor.

This change updates ModelAttributeMethodProcessor accordingly, and deprecates MethodArgumentNotValidException(Executable, BindingResult) in favor of MethodArgumentNotValidException(MethodParameter, BindingResult).
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels May 30, 2023
@sdeleuze sdeleuze added this to the 6.0.10 milestone May 30, 2023
@sdeleuze sdeleuze self-assigned this May 30, 2023
@sdeleuze sdeleuze mentioned this issue May 30, 2023
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue May 30, 2023
@sdeleuze
Always use MethodArgumentNotValidException(MethodParameter, BindingRe…
34307a5 
…sult) constructor

spring-projectsgh-23846 introduced a new
MethodArgumentNotValidException(Executable, BindingResult) constructor
that can be advantageously replaced by using
MethodArgumentNotValidException(MethodParameter, BindingResult)
in ModelAttributeMethodProcessor.

This commit updates ModelAttributeMethodProcessor accordingly,
and deprecates MethodArgumentNotValidException(Executable,
BindingResult) in favor of
MethodArgumentNotValidException(MethodParameter, BindingResult).

Closes spring-projectsgh-30558
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@sdeleuze @mdeinum
Always use MethodArgumentNotValidException(MethodParameter, BindingRe…
8bd2715 
…sult) constructor

spring-projectsgh-23846 introduced a new
MethodArgumentNotValidException(Executable, BindingResult)
constructor that can be advantageously replaced by using
MethodArgumentNotValidException(MethodParameter, BindingResult)
in ModelAttributeMethodProcessor.

This commit updates ModelAttributeMethodProcessor accordingly,
and deprecates MethodArgumentNotValidException(Executable,
BindingResult) in favor of
MethodArgumentNotValidException(MethodParameter, BindingResult).

Closes spring-projectsgh-30558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.10
Development

No branches or pull requests
1 participant
@sdeleuze