Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare Advisor#isPerInstance() as default method #30614

Closed
jhoeller opened this issue Jun 7, 2023 · 0 comments
Closed

Declare Advisor#isPerInstance() as default method #30614

jhoeller opened this issue Jun 7, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.0.10

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Jun 7, 2023

In the course of #26266, it turns out that Advisors are unnecessarily forced to implement the Advisor#isPerInstance() method. Declaring it as a default method that returns true is a convenient improvement there.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jun 7, 2023
@jhoeller jhoeller added this to the 6.0.10 milestone Jun 7, 2023
@jhoeller jhoeller self-assigned this Jun 7, 2023
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Declare Advisor#isPerInstance() as default method
966d2ec 
Includes INSTANCE constants on default factory classes.

Closes spring-projectsgh-30614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.10
Development

No branches or pull requests
1 participant
@jhoeller