Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign inner Pointcut implementations as standalone classes #30621

Closed
jhoeller opened this issue Jun 8, 2023 · 0 comments
Closed

Redesign inner Pointcut implementations as standalone classes #30621

jhoeller opened this issue Jun 8, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.0.10

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Jun 8, 2023

In the course of #26266, it turned out to be suboptimal to have Pointcut implementations attached to an enclosing class, e.g. for transaction attribute sources and cache operation sources. It is preferable for the necessary state to be locally concealed within the Pointcut instance.

Also, JCacheOperationSourcePointcut turned out to be accidentally public and will be deprecated as of 6.0.10 now.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jun 8, 2023
@jhoeller jhoeller added this to the 6.0.10 milestone Jun 8, 2023
@jhoeller jhoeller self-assigned this Jun 8, 2023
jhoeller added a commit that referenced this issue Jun 8, 2023
@jhoeller
Redesign inner Pointcut implementations as standalone classes
6931106 
Avoids exposure of implicit Advisor instance state in Pointcut instance.

See gh-30621
@jhoeller jhoeller closed this as completed Jun 8, 2023
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Redesign inner Pointcut implementations as standalone classes
ef42c0f 
Avoids exposure of implicit Advisor instance state in Pointcut instance.

See spring-projectsgh-30621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.10
Development

No branches or pull requests
1 participant
@jhoeller