Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassLoader can be null in DeserializingConverter and should be annotated with @Nullable #30670

Closed
jxblum opened this issue Jun 14, 2023 · 0 comments
Closed

ClassLoader can be null in DeserializingConverter and should be annotated with @Nullable #30670

jxblum opened this issue Jun 14, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.10

Comments

@jxblum
Copy link

jxblum commented Jun 14, 2023

Given the DefaultDeserializer allows the ClassLoader to be null, then it follows that the DeserializingConverter should allow a null ClassLoader on construction.

Because the ClassLoader constructor parameter is not declared @Nullable in contexts (such as other framework code; for example, in SD Redis) where a ClassLoader may not be provided, a compiler warning is present.

Indeed, a ClassLoader is not strictly required to carry out the function of the DeserializingConverter.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 14, 2023
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 14, 2023
@jhoeller jhoeller self-assigned this Jun 14, 2023
@jhoeller jhoeller added this to the 6.0.10 milestone Jun 14, 2023
@jhoeller jhoeller added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Jun 14, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Jun 14, 2023
@github-actions github-actions bot mentioned this issue Jun 14, 2023
Closed
jhoeller added a commit that referenced this issue Jun 14, 2023
@jhoeller
Declare ClassLoader for DeserializingConverter constructor as nullable
99ae6e7 
Closes gh-30670

(cherry picked from commit b922165)
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Declare ClassLoader for DeserializingConverter constructor as nullable
4a874cf 
Closes spring-projectsgh-30670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.10
Development

No branches or pull requests
3 participants
@jhoeller @jxblum @spring-projects-issues