Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that RowCallbackHandler can be used with NamedParameterJdbcTemplate #30705

Closed
manueljordan opened this issue Jun 20, 2023 · 2 comments
Closed

Document that RowCallbackHandler can be used with NamedParameterJdbcTemplate #30705

manueljordan opened this issue Jun 20, 2023 · 2 comments
Assignees
@sbrannen
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task
Milestone
6.0.11

Comments

@manueljordan
Copy link

About the javadoc for the RowCallbackHandler interface, currently it indicates at the beginning:

An interface used by JdbcTemplate for processing rows of a ResultSet

I think it should be

An interface used by JdbcTemplate and NamedParameterJdbcTemplate for processing rows of a ResultSet

I've confirmed that the NamedParameterJdbcTemplate class have many methods working through/with RowCallbackHandler . I used a pair of them and works fine.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 20, 2023
@sbrannen sbrannen self-assigned this Jun 21, 2023
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 21, 2023
@sbrannen sbrannen added this to the 6.0.11 milestone Jun 21, 2023
@sbrannen sbrannen changed the title Document that RowCallbackHandler can work with NamedParameterJdbcTemplate too Document that RowCallbackHandler can be used with NamedParameterJdbcTemplate Jun 21, 2023
@manueljordan
Copy link
Author

manueljordan commented Jun 22, 2023 •
edited

Just being curious, why in the javadoc for some references/mentions of NamedParameterJdbcTemplate is included its package? That approach was not applied for the current reference/mention of JdbcTemplate

@sbrannen
Copy link
Member

why in the javadoc for some references/mentions of NamedParameterJdbcTemplate is included its package?

because it resides in a different package and is not directly used within the class in question.

This is standard procedure within Spring and many projects: we don't import types that are not used in the code.

mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@sbrannen @mdeinum
Document that RowCallbackHandler can be used w/ NamedParameterJdbcTem…
3252726 
…plate

Closes spring-projectsgh-30705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task
Projects
None yet
Milestone
6.0.11
Development

No branches or pull requests
3 participants
@sbrannen @manueljordan @spring-projects-issues