Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResolvableType.hasUnresolvableGenerics() should cache its result #30713

Closed
jhoeller opened this issue Jun 21, 2023 · 0 comments
Closed

ResolvableType.hasUnresolvableGenerics() should cache its result #30713

jhoeller opened this issue Jun 21, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.11

Comments

@jhoeller
Copy link
Contributor

As part of restoring lenient matching for events with unresolvable generics in #30712, it turns out that we're calling ResolvableType.hasUnresolvableGenerics() on the given event type quite often. It seems sensible to cache it within ResolvableType itself, also to the benefit of our conditional type converter matching etc.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jun 21, 2023
@jhoeller jhoeller added this to the 6.0.11 milestone Jun 21, 2023
@jhoeller jhoeller self-assigned this Jun 21, 2023
@jhoeller jhoeller added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Jun 21, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Jun 21, 2023
@github-actions github-actions bot mentioned this issue Jun 21, 2023
Closed
jhoeller added a commit that referenced this issue Jun 21, 2023
@jhoeller
Cache hasUnresolvableGenerics result for repeated checks
5375f62 
Closes gh-30713

(cherry picked from commit 93218a0)
jhoeller added a commit that referenced this issue Jun 21, 2023
@jhoeller
Avoid ResolvableType creation for interface/superclass check
1dfe737 
See gh-30713
jhoeller added a commit that referenced this issue Jun 21, 2023
@jhoeller
Avoid ResolvableType creation for interface/superclass check
d3df45d 
See gh-30713

(cherry picked from commit 1dfe737)
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Cache hasUnresolvableGenerics result for repeated checks
8643b57 
Closes spring-projectsgh-30713
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Avoid ResolvableType creation for interface/superclass check
a4a8dd1 
See spring-projectsgh-30713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.11
Development

No branches or pull requests
1 participant
@jhoeller