Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide explicit support for collections, maps, and arrays in ObjectUtils.nullSafeConciseToString() #30810

Closed
sbrannen opened this issue Jul 4, 2023 · 0 comments
Closed

Provide explicit support for collections, maps, and arrays in ObjectUtils.nullSafeConciseToString() #30810

sbrannen opened this issue Jul 4, 2023 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.11

Comments

@sbrannen
Copy link
Member

sbrannen commented Jul 4, 2023 •
edited

Overview

Inspired by comments in the description of #30799.

Related Issues
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jul 4, 2023
@sbrannen sbrannen self-assigned this Jul 4, 2023
@sbrannen sbrannen added this to the 6.0.11 milestone Jul 4, 2023
@sbrannen sbrannen added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Jul 4, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Jul 4, 2023
@github-actions github-actions bot mentioned this issue Jul 4, 2023
Closed
This was referenced Jul 4, 2023
Closed
Closed
sbrannen added a commit that referenced this issue Jul 6, 2023
@sbrannen
Update Javadoc for ObjectUtils.nullSafeConciseToString()
ad05b02 
See gh-30810
@jhoeller jhoeller mentioned this issue Sep 2, 2023
Closed
sbrannen added a commit that referenced this issue Sep 8, 2023
@sbrannen
Do not invoke [Map|Collection].isEmpty() in nullSafeConciseToString()
ea41051 
gh-30810 introduced explicit support for collections and maps in
ObjectUtils.nullSafeConciseToString() by invoking isEmpty() on a Map or
Collection to determine which concise string representation should be
used. However, this caused a regression in which an exception was
thrown if the Map or Collection was a proxy generated by
AbstractFactoryBean to support <util:set />, <util:list />, and
<util:map /> in XML configuration.

This commit addresses this set of regressions by always returning
"[...]" or "{...}" for a Collection or Map, respectively, disregarding
whether the map is empty or not.

Closes gh-31138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.11
Development

No branches or pull requests
1 participant
@sbrannen