Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GeneratedClasses#withFeatureNamePrefix(String) public #30897

Closed
sbrannen opened this issue Jul 15, 2023 · 4 comments
Closed

Make GeneratedClasses#withFeatureNamePrefix(String) public #30897

sbrannen opened this issue Jul 15, 2023 · 4 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply theme: aot An issue related to Ahead-of-time processing

Comments

@sbrannen
Copy link
Member

Overview

The GeneratedClasses#withFeatureNamePrefix(String) method is currently package-private which prevents code from other packages from being able to create a new GeneratedClasses instance with a feature name prefix based on an existing GeneratedClasses instance.

Related Issues
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Jul 15, 2023
@sbrannen sbrannen added this to the 6.0.12 milestone Jul 15, 2023
@sbrannen sbrannen self-assigned this Jul 15, 2023
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jul 15, 2023
@sbrannen
Make GeneratedClasses#withFeatureNamePrefix(String) public
361344f 
See spring-projectsgh-30861
Closes spring-projectsgh-30897
@snicoll
Copy link
Member

snicoll commented Jul 15, 2023

Can we please hold? I’d like to avoid exposing too many public APIs there.

@sbrannen
Copy link
Member Author

Can we please hold? I’d like to avoid exposing too many public APIs there.

Oh. I didn't see your comment until I'd completed the work and pushed it. Sorry about that.

Making that method public seemed the easiest way to achieve the goals of #30861.

However, let me see if I can figure out a way to achieve that part of the feature without making GeneratedClasses#withFeatureNamePrefix(String) public.

@sbrannen
Copy link
Member Author

Reopening to address the need in a different manner.

@sbrannen sbrannen reopened this Jul 15, 2023
@sbrannen sbrannen removed this from the 6.0.12 milestone Jul 15, 2023
@sbrannen sbrannen added the status: declined A suggestion or change that we don't feel we should currently apply label Jul 15, 2023
@sbrannen
Copy link
Member Author

Closing as "not planned" due to the change of focus in #30895.

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2023
@snicoll snicoll removed the type: enhancement A general enhancement label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply theme: aot An issue related to Ahead-of-time processing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbrannen @snicoll