Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize whitespace checks in StringUtils #31067

Closed
jhoeller opened this issue Aug 18, 2023 · 1 comment
Closed

Optimize whitespace checks in StringUtils #31067

jhoeller opened this issue Aug 18, 2023 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.12

Comments

@jhoeller
Copy link
Contributor

On review, StringUtils has some suboptimal whitespace checks: For hasText(String), it can use the JDK 11+ String.isBlank() method, and in trimAllWhitespace(CharSequence), it unnecessarily returns StringBuilder.toString() instead of just the StringBuilder itself.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Aug 18, 2023
@jhoeller jhoeller added this to the 6.0.12 milestone Aug 18, 2023
@jhoeller jhoeller self-assigned this Aug 18, 2023
@jhoeller jhoeller added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Aug 18, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Aug 18, 2023
@github-actions github-actions bot mentioned this issue Aug 18, 2023
Closed
@jhoeller
Copy link
Contributor Author

While JDK 11's isBlank() can only be used in Spring Framework 6.0+, the other refinements can be backported to 5.3.x as well.

jhoeller added a commit that referenced this issue Aug 18, 2023
@jhoeller
Optimize whitespace checks in StringUtils (as far as possible on JDK 8)
493f75e 
Closes gh-31067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.12
Development

No branches or pull requests
1 participant
@jhoeller