Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide mock implementation of org.springframework.web.servlet.function.ServerRequest #31087

Closed
vpavic opened this issue Aug 21, 2023 · 2 comments
Closed

Provide mock implementation of org.springframework.web.servlet.function.ServerRequest #31087

vpavic opened this issue Aug 21, 2023 · 2 comments
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@vpavic
Copy link
Contributor

vpavic commented Aug 21, 2023

Testing org.springframework.web.servlet.function.HandlerFunction implementations would be easier if spring-test would provide a mock implementation of org.springframework.web.servlet.function.ServerRequest, analogous to the org.springframework.mock.web.reactive.function.server.MockServerRequest (that implements the reactive counterpart org.springframework.web.reactive.function.server.ServerRequest).
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 21, 2023
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 22, 2023
@sbrannen sbrannen added this to the 6.1.x milestone Aug 22, 2023
@PeguB PeguB mentioned this issue Sep 18, 2023
Open
@PeguB
Copy link

PeguB commented Sep 19, 2023

Hello, I would like to claim this issue.
I made a PR in advance that includes the required changes.

@bclozel
Copy link
Member

bclozel commented Sep 19, 2023

Superseded by #31257

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
@bclozel bclozel added the status: superseded An issue that has been superseded by another label Sep 19, 2023
@bclozel bclozel removed this from the 6.1.x milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bclozel @sbrannen @vpavic @spring-projects-issues @PeguB