Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Servlet 6.1 #31159

Closed
jhoeller opened this issue Sep 3, 2023 · 1 comment
Closed

Initial support for Servlet 6.1 #31159

jhoeller opened this issue Sep 3, 2023 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Sep 3, 2023

Along with JPA 3.2 (#31157), the most interesting additions to Jakarta EE 11 are happening in Servlet 6.1, e.g. ByteBuffer support on ServletInputStream and ServletOutputStream:

https://deploy-preview-652--jakartaee-specifications.netlify.app/specifications/servlet/6.1/

@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Sep 3, 2023
@jhoeller jhoeller added this to the 6.1.x milestone Sep 3, 2023
@jhoeller jhoeller modified the milestones: 6.1.x, 6.2.x Sep 27, 2023
@jhoeller
Copy link
Contributor Author

It turns out that the built-in Servlet ByteBuffer support is not actually useful for us since we override it for Tomcat already and do not use the Servlet-based variant at all for Undertow and soon also for Jetty 12 (#32035). We could start using it reflectively when present in ServletHttpHandlerAdapter itself but that's not actually in use in its raw form on any common server, so we might rather upgrade that part once we have a Jakarta EE 11 baseline and therefore do not need reflective invocations anymore.

That said, there are a couple of new overloaded methods in Servlet 6.1, e.g. for sendRedirect. Supporting those in our mocks is straightforward, so I'll roll that part into 6.2 M1 right away.

@jhoeller jhoeller self-assigned this Feb 28, 2024
@jhoeller jhoeller modified the milestones: 6.2.x, 6.2.0-M1 Feb 28, 2024
@jhoeller jhoeller changed the title Support for Servlet 6.1 Initial support for Servlet 6.1 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant