Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject @RequestMapping and @HttpExchange declarations on the same element #32065

Closed
sbrannen opened this issue Jan 19, 2024 · 1 comment
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@sbrannen
Copy link
Member

Overview

As a follow up to #31962 and #32049, we have decided to reject adjacent @RequestMapping and @HttpExchange declarations on a @Controller class or on a @Controller handler method in MVC and WebFlux.

Note, however, that doing so will still allow a @Controller class which implements an interface annotated with @HttpExchange annotations to inherit the @HttpExchange declarations from the interface or optionally override them locally with @HttpExchange or @RequestMapping annotations.

Related Issues

@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jan 19, 2024
@sbrannen sbrannen added this to the 6.1.4 milestone Jan 19, 2024
@sbrannen sbrannen self-assigned this Jan 19, 2024
@sbrannen
Copy link
Member Author

Note, however, that doing so will still allow a @Controller class which implements an interface annotated with @HttpExchange annotations to inherit the @HttpExchange declarations from the interface or optionally override them locally with @HttpExchange or @RequestMapping annotations.

Reopening to ensure the above is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant