Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send Server-Sent Events without data using WebMvc.fn SseBuilder #32270

Closed
bclozel opened this issue Feb 14, 2024 · 0 comments
Closed

Cannot send Server-Sent Events without data using WebMvc.fn SseBuilder #32270

bclozel opened this issue Feb 14, 2024 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Feb 14, 2024

The Server-Sent Events specification does not require events to have a data: field in them. The current SeeBuilder spec in WebMvc.fn enforces this because all terminal methods require a data: field.

We should add a send() operation to send all buffered id, event and comment as is, without adding any data field. Because the spec doesn't require data: fields, we are considering this as a bug.

This will be useful for implementing the GraphQL over SSE transport in Spring for GraphQL.

@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Feb 14, 2024
@bclozel bclozel added this to the 6.1.4 milestone Feb 14, 2024
@bclozel bclozel self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant