Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce NoOp implementation for ResponseErrorHandler #32750

Closed
snicoll opened this issue May 2, 2024 · 0 comments
Closed

Introduce NoOp implementation for ResponseErrorHandler #32750

snicoll opened this issue May 2, 2024 · 0 comments
Assignees
@snicoll
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.1.7

Comments

@snicoll
Copy link
Member

snicoll commented May 2, 2024 •
edited

There are cases where you'd like to not do anything special in case of error. Spring Boot already does that for its TestRestTemplate. ResponseErrorHandler makes it a tad harder as it has two handleError methods depending on the level of information available. This changed recently (#28958) which broke them.

Introducing a noop implementation that SB and others can use would be beneficial.
@snicoll snicoll added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels May 2, 2024
@snicoll snicoll added this to the 6.1.7 milestone May 2, 2024
@snicoll snicoll self-assigned this May 2, 2024
@snicoll snicoll changed the title Introduce NO_OP implementation for ResponseErrorHandler Introduce NoOp implementation for ResponseErrorHandler May 2, 2024
@snicoll snicoll closed this as completed in f90bdbe May 2, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 2, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
6851c70 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 2, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
73b4746 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 3, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
6d3ef79 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 7, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
b2915a1 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 7, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
e9aa91a 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 8, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
782b895 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 21, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
4d785ae 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 22, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
f123ada 
See spring-projects/spring-framework#32750
snicoll added a commit to snicoll/spring-boot that referenced this issue May 22, 2024
@snicoll
Use Spring Framework's NoOpResponseErrorHandler
8d17f0e 
See spring-projects/spring-framework#32750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.7
Development

No branches or pull requests
1 participant
@snicoll