Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check in isBridgedCandidateFor() #27862

Closed
wants to merge 3 commits into from

Conversation

aoyvx
Copy link
Contributor

@aoyvx aoyvx commented Dec 28, 2021

In BridgeMethodResolver#isBridgedCandidateFor, candidateMethod is never not bridged, so it seems unnecessary to judge whether candidateMethod and bridgeMethod are the same.

@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement labels Jan 3, 2022
@sbrannen sbrannen changed the title An unnecessary judgment was removed Remove unnecessary check in isBridgedCandidateFor() Jan 3, 2022
@rstoyanchev
Copy link
Contributor

Seems like a valid point that if they are the same method, then if isBridge is false on one, it's false on both. This might be more about explicitness, what do you think, @jhoeller?

@rstoyanchev rstoyanchev added this to the Triage Queue milestone Jan 4, 2022
@jhoeller
Copy link
Contributor

jhoeller commented Jan 4, 2022

Good point, in the given context that this internal method is called within, they are never going to be equal indeed if the candidate is not a bridge.

@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 4, 2022
@jhoeller jhoeller modified the milestones: Triage Queue, 6.0.0-M2 Jan 4, 2022
@sbrannen sbrannen self-assigned this Jan 11, 2022
@sbrannen sbrannen closed this in 6ecb488 Jan 11, 2022
sbrannen added a commit that referenced this pull request Jan 11, 2022
@sbrannen
Copy link
Member

This has been merged into main.

Thanks

@aoyvx aoyvx deleted the me/BridgeMethodResolver branch February 16, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants