Feature/spring5 #2273

iles-2e · 2018-03-01T13:54:22Z

What's this PR do/fix?

Updates dependencies to match those in Spring Boot 2

springBoot 1.5.9.RELEASE -> 2.0.0.RELEASE
spring 4.3.9.RELEASE -> 5.0.4.RELEASE
springDataRest 2.6.9.RELEASE -> 3.0.5.RELEASE

Minimum JDK version is updated to 1.8 (Spring requirement)

Are there unit tests? If not how should this be manually tested?

No new methods were added nor was any method removed, thus no new unit tests. Code fixes were limited to fixing API incompatible changes after the upgrade.

Any background context you want to provide?

My motivation was to make Springfox work in a Spring5 environment. I'm using it in a project running Spring MVC (5) and Spring Data Rest (Kay).

What are the relevant issues?

#1773
#1957

…y modifications

…g picked up

…encies upgraded to match those in boot

iles-2e · 2018-03-01T14:15:39Z

Tests probably failed due to running under Java 7:

Support for running Gradle using Java 7 has been deprecated and is scheduled to be removed in Gradle 5.0.

PascalSchumacher · 2018-03-01T14:25:44Z

https://github.com/springfox/springfox/blob/master/circle.yml uses java 7, so that has to be updated too.

codecov · 2018-03-01T14:44:43Z

Codecov Report

Merging #2273 into master will increase coverage by 0.05%.
The diff coverage is 96.56%.

@@             Coverage Diff              @@
##             master    #2273      +/-   ##
============================================
+ Coverage     95.03%   95.08%   +0.05%     
- Complexity     3057     3101      +44     
============================================
  Files           340      341       +1     
  Lines          7809     7828      +19     
  Branches        596      597       +1     
============================================
+ Hits           7421     7443      +22     
+ Misses          240      238       -2     
+ Partials        148      147       -1

iles-2e · 2018-03-01T15:07:01Z

@PascalSchumacher Good catch! Thank you! :)

dilipkrish · 2018-03-03T03:14:38Z

Thanks for the PR!! just FYI I will hold it in the wings, just a little bit until we get 2.9.0 out of the way (the last supported version using 1.6 jdk)

Conflicts: gradle/dependencies.gradle

bastelfreak · 2018-03-08T22:54:42Z

Hi @iles-2e, thanks for the work!
@dilipkrish thanks for the awesome project. Do you have any rough ETA for this? I would love to use swagger-ui on my new springboot v2 project.

dilipkrish · 2018-03-09T00:33:53Z

Thanks @bastelfreak. Sometime in April mid I'd reckon

ronanquillevere · 2018-03-27T12:11:36Z

👍

raderio · 2018-04-03T20:12:15Z

just a little bit until we get 2.9.0 out of the way (the last supported version using 1.6 jdk)

any ETA for 2.9.0?

dilipkrish · 2018-04-04T11:19:34Z

In the next few days

predrag-viceic · 2018-04-20T07:36:20Z

Hello !

Is this feature being merged in 2.9.0 ? I have tried the build snapshots, but still get the exception.

dilipkrish · 2018-04-24T10:57:12Z

@predrag-viceic it will be merged in post 2.9.0

@iles-2e would you mind squashing your merge commits? Let me know if you need help with that.

mikezerosix · 2018-05-04T09:36:26Z

@dilipkrish "post 2.9.0" is a bit vaque.

With current Spring Boot (Data REST) version the Swagger 2 is and has been completely broken for a while now.

As it is now Swagger in completely unusable for modern SW development.

dilipkrish · 2018-05-05T15:34:14Z

unusable for modern SW development

@mikezerosix thats a pretty broad statement :)

Anyways, trying to get a release to maven central and the next release will be focused on spring5/boot2/oas 3.0 compatibility.

iles-2e · 2018-05-09T13:03:54Z

@dilipkrish sorry for the late reply... merged recent changes again and squashed previous merge commits.

predrag-viceic · 2018-05-24T07:46:50Z

Hello,

Any ETA on this feature ? This project is extremely useful and I have some models that are used only in spring data rest.. For now I'm implementing some fake spring mvc services so the models get exported in the documentation, but it would be really cool to have at least the level of features we had with spring 4..

Anyway, thanks a lot for your work !

dilipkrish · 2018-05-31T12:33:12Z

@predrag-viceic sorry its taking a bit of time. Hopefully in the next couple of months

predrag-viceic · 2018-06-28T13:30:43Z

@iles-2e

Hello,
I have built your branch, and after some tweaks, it works pretty well ! Thanks !

I have a question: is it possible to document the association endpoints? ie, right now, They are correctly generated, but with names such as baseentityAssociation, and there is no way to add @ApiOperation comment to these because they do not really exist at the <Crud, pagingAndSorting,etc..>interface level.

dilipkrish · 2018-06-30T21:21:44Z

@iles-2e Sorry Im just getting to this PR, I didn't realize there was a PR for upgrading spring data rest. I updated master to support this and also be java 8 source compliant. Since I dont have context into some of your changes, which may include bug fixes as well, would you be able to resolve the merge conflicts.

Conflicts: gradle/dependencies.gradle springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityAssociationDeleteExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityAssociationGetExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityAssociationItemDeleteExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityAssociationItemGetExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityAssociationSaveExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityAssociationsExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityContext.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityDeleteExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityFindAllExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityFindOneExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntitySaveExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntitySearchExtractor.java springfox-data-rest/src/main/java/springfox/documentation/spring/data/rest/EntityServicesProvider.java springfox-schema/src/main/java/springfox/documentation/schema/property/OptimizedModelPropertiesProvider.java springfox-spring-web/src/main/java/springfox/documentation/spring/web/ControllerNamingUtils.java swagger-contract-tests/build.gradle

iles-2e · 2018-07-09T07:49:14Z

@dilipkrish sorry for the late response... I merged the default and resolved the conflicts. My changes were mostly dependency upgrade and introduction of Optional due to Spring Data API change, plus some code duplication removal.

Also there is a fix for Jackson upgrade above 2.9 version. They started to pick up setterless properties which in most cases (at least in tests) are false positive so the fix was to revert the behavior.

dilipkrish · 2018-07-11T01:42:23Z

Thank you @iles-2e I've merged it in finally! sorry for the long wait!

iles-2e added 8 commits February 15, 2018 13:44

springfox#1773 Initial dependency upgrade along with API compatibilit…

b7378f2

…y modifications

springfox#1773 jackson-binding:2.9 fix for setterless properties bein…

848d725

…g picked up

springfox#1773 data-rest: repository description fix

b9450ce

springfox#1773 contract-tests: adding Spring Boot 2

8516de6

springfox#1773 contract-tests: contract changed with Spring Data Kay

7300938

springfox#1773 springfox: Adding Spring Boot 2 (RC2) globally

101d19f

springfox#1773 springfox: spring-boot:2.0.0.RELEASE with other depend…

8c3474e

…encies upgraded to match those in boot

Merge branch 'master' into feature/spring5

bc8744c

PascalSchumacher mentioned this pull request Mar 1, 2018

springfox-data-rest v3 support #2272

Closed

Updating CircleCI build to jdk8

ae261e7

Merge branch 'master' into feature/spring5

3862cd9

Conflicts: gradle/dependencies.gradle

iles-2e added 3 commits March 9, 2018 14:31

Merge branch 'master' into feature/spring5

7d11a78

Merge fix

f206ff9

spring-data-rest: remove Guava from EntityAssociationsExtractor

c60fbbf

dilipkrish added the PR label Mar 10, 2018

spring-data-rest: DRY it up and reduce Guava

1b21b17

springfox deleted a comment Mar 14, 2018

Merge branch 'master' into feature/spring5

3d664a3

iles-2e force-pushed the feature/spring5 branch from 63b2d5c to 3d664a3 Compare May 9, 2018 12:39

iles-2e added 4 commits July 6, 2018 15:02

Merge fix

c5169ad

Contract fix for Jackson 2.9+ behavior change

8a813ee

Unused import removed

79c8ae9

dilipkrish merged commit 79c8ae9 into springfox:master Jul 11, 2018

dilipkrish added this to the 3.0 milestone Jul 11, 2018

dilipkrish mentioned this pull request Jul 14, 2020

Announcement: 3.0.0 Release #3386

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/spring5 #2273

Feature/spring5 #2273

iles-2e commented Mar 1, 2018

iles-2e commented Mar 1, 2018

PascalSchumacher commented Mar 1, 2018 •

edited

codecov bot commented Mar 1, 2018 •

edited

iles-2e commented Mar 1, 2018

dilipkrish commented Mar 3, 2018

bastelfreak commented Mar 8, 2018

dilipkrish commented Mar 9, 2018

ronanquillevere commented Mar 27, 2018

raderio commented Apr 3, 2018 •

edited

dilipkrish commented Apr 4, 2018

predrag-viceic commented Apr 20, 2018

dilipkrish commented Apr 24, 2018

mikezerosix commented May 4, 2018

dilipkrish commented May 5, 2018

iles-2e commented May 9, 2018

predrag-viceic commented May 24, 2018

dilipkrish commented May 31, 2018

predrag-viceic commented Jun 28, 2018

dilipkrish commented Jun 30, 2018

iles-2e commented Jul 9, 2018

dilipkrish commented Jul 11, 2018

Feature/spring5 #2273

Feature/spring5 #2273

Conversation

iles-2e commented Mar 1, 2018

What's this PR do/fix?

Are there unit tests? If not how should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

iles-2e commented Mar 1, 2018

PascalSchumacher commented Mar 1, 2018 • edited

codecov bot commented Mar 1, 2018 • edited

Codecov Report

iles-2e commented Mar 1, 2018

dilipkrish commented Mar 3, 2018

bastelfreak commented Mar 8, 2018

dilipkrish commented Mar 9, 2018

ronanquillevere commented Mar 27, 2018

raderio commented Apr 3, 2018 • edited

dilipkrish commented Apr 4, 2018

predrag-viceic commented Apr 20, 2018

dilipkrish commented Apr 24, 2018

mikezerosix commented May 4, 2018

dilipkrish commented May 5, 2018

iles-2e commented May 9, 2018

predrag-viceic commented May 24, 2018

dilipkrish commented May 31, 2018

predrag-viceic commented Jun 28, 2018

dilipkrish commented Jun 30, 2018

iles-2e commented Jul 9, 2018

dilipkrish commented Jul 11, 2018

PascalSchumacher commented Mar 1, 2018 •

edited

codecov bot commented Mar 1, 2018 •

edited

raderio commented Apr 3, 2018 •

edited