New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a FormParameter model object instead of BodyParameter #2722
Conversation
…ds that are part of a multipart form (in=formData).
I've adapted the class so that it only maps to FormParameter now if the type is one of the types supported by the spec. In other cases it falls back to BodyParameter, which is seemingly wrong, but matches previous behavior better. |
Whats up with this PR? Can you please get it fixed so we would not have to build based on your repo on Monday :) |
@shartte thanks for the PR. It appears that the contract tests are failing. Would you mind taking a look? |
@dilipkrish Will do, I had some issues with getting them to run initially, but now they work for me. So I'll investigate. |
Codecov Report
@@ Coverage Diff @@
## master #2722 +/- ##
============================================
- Coverage 94.77% 94.71% -0.06%
- Complexity 3161 3166 +5
============================================
Files 354 354
Lines 8057 8081 +24
Branches 608 612 +4
============================================
+ Hits 7636 7654 +18
- Misses 271 276 +5
- Partials 150 151 +1
|
Having issues with #2717 |
Create a FormParameter model object instead of BodyParameter related to #2722
This fixes #2717 by creating the right Swagger model class for parameters of type "formData".
Since those parameters only support a single example, I've also opted to simply copy over the first one.