Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve examples #2778

Merged
merged 4 commits into from Nov 15, 2018
Merged

Conversation

dschulten
Copy link
Contributor

What's this PR do/fix?

This PR ensures that Examples added with ApiResponse annotations are no longer dropped when merging ResponseMessages in OperationBuilder.

Are there unit tests? If not how should this be manually tested?

OperationBuilderSpec
def "Response message builder is non-destructive"

Any background context you want to provide?

I need examples to add response example snippets created by spring-restdocs in spring-integration for springfox

What are the relevant issues?

None

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2778 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2778      +/-   ##
============================================
+ Coverage     94.77%   94.78%   +<.01%     
  Complexity     3161     3161              
============================================
  Files           354      354              
  Lines          8057     8067      +10     
  Branches        608      608              
============================================
+ Hits           7636     7646      +10     
  Misses          271      271              
  Partials        150      150
Impacted Files Coverage Δ Complexity Δ
...ngfox/documentation/builders/OperationBuilder.java 100% <100%> (ø) 26 <0> (ø) ⬇️

@dilipkrish dilipkrish added the PR label Nov 15, 2018
@dilipkrish dilipkrish merged commit 1174d01 into springfox:master Nov 15, 2018
@dilipkrish
Copy link
Member

Thank you @dschulten for catching that!

@dilipkrish dilipkrish added this to the 3.0 milestone Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants