Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for 3.3. Springfox Spring Data Rest #2810

Merged
merged 1 commit into from Dec 17, 2018

Conversation

paulvi
Copy link
Contributor

@paulvi paulvi commented Dec 7, 2018

Documentation for 3.3. Springfox Spring Data Rest - make 2 steps clear

What's this PR do/fix?

https://springfox.github.io/springfox/docs/current/#springfox-spring-data-rest

currently (at first look) is not clear as 2 steps are needed

Are there unit tests? If not how should this be manually tested?

just docs update

Any background context you want to provide?

What are the relevant issues?

answer to SO Q https://stackoverflow.com/questions/22340357/swagger-with-spring-data-rest
may misslead about 2nd step

Documentation for 3.3. Springfox Spring Data Rest - make 2 steps clear
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2810   +/-   ##
=========================================
  Coverage     94.43%   94.43%           
  Complexity     3220     3220           
=========================================
  Files           364      364           
  Lines          8297     8297           
  Branches        618      618           
=========================================
  Hits           7835     7835           
  Misses          304      304           
  Partials        158      158

1 similar comment
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2810   +/-   ##
=========================================
  Coverage     94.43%   94.43%           
  Complexity     3220     3220           
=========================================
  Files           364      364           
  Lines          8297     8297           
  Branches        618      618           
=========================================
  Hits           7835     7835           
  Misses          304      304           
  Partials        158      158

@dilipkrish
Copy link
Member

Thanks for the PR!

@dilipkrish dilipkrish merged commit 379f0ce into springfox:master Dec 17, 2018
@dilipkrish dilipkrish added the PR label Dec 17, 2018
@dilipkrish dilipkrish added this to the 3.0 milestone Dec 17, 2018
@paulvi paulvi deleted the patch-1 branch January 29, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants