Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2822 related to @ApiParam(example="..") not working for @Request… #2824

Merged
merged 1 commit into from Dec 17, 2018

Conversation

StasKolodyuk
Copy link

…Body

What's this PR do/fix?

Fixes @ApiParam(example="..") not workin for @requestbody

Are there unit tests? If not how should this be manually tested?

Yes

Any background context you want to provide?

No

What are the relevant issues?

#2822

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #2824 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2824      +/-   ##
============================================
+ Coverage     94.43%   94.43%   +<.01%     
- Complexity     3220     3226       +6     
============================================
  Files           364      364              
  Lines          8297     8302       +5     
  Branches        618      619       +1     
============================================
+ Hits           7835     7840       +5     
  Misses          304      304              
  Partials        158      158
Impacted Files Coverage Δ Complexity Δ
...ocumentation/swagger2/mappers/ParameterMapper.java 90.38% <100%> (+1.02%) 16 <6> (+6) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #2824 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2824      +/-   ##
============================================
+ Coverage     94.43%   94.43%   +<.01%     
- Complexity     3220     3226       +6     
============================================
  Files           364      364              
  Lines          8297     8302       +5     
  Branches        618      619       +1     
============================================
+ Hits           7835     7840       +5     
  Misses          304      304              
  Partials        158      158
Impacted Files Coverage Δ Complexity Δ
...ocumentation/swagger2/mappers/ParameterMapper.java 90.38% <100%> (+1.02%) 16 <6> (+6) ⬆️

@dilipkrish
Copy link
Member

Thanks for the PR!

@dilipkrish dilipkrish merged commit db8e4d1 into springfox:master Dec 17, 2018
@viswanadhraju
Copy link

Hi Dilip,

You are doing the great job as part of springfox community, i can not stop appreciating this effort.
I'm asking out of my curiosity, is there any release date for API 3.0 ?

warm regards,
Viswa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants