Fix #2247 maps Enum constants to value of name() rather than toString() #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
=========================================
Coverage 94.43% 94.43%
Complexity 3226 3226
=========================================
Files 364 364
Lines 8302 8302
Branches 619 619
=========================================
Hits 7840 7840
Misses 304 304
Partials 158 158
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
=========================================
Coverage 94.43% 94.43%
Complexity 3226 3226
=========================================
Files 364 364
Lines 8302 8302
Branches 619 619
=========================================
Hits 7840 7840
Misses 304 304
Partials 158 158
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of springfox mapping Enum constants to the value of their toString() implementation by default (i.e. when no Jackson annotations are present) rather than name(). An Enum's toString() implementation can be overridden by the user in a way that makes it impossible to convert the value back to an Enum constant using Enum.valueOf() and leads to a situation where SwagggerUI cannot supply a valid parameter to an affected endpoint.
I've updated EnumSpec to reflect this change. The existing test for duplicate values is no longer relevant as name() is guaranteed to be unique per Enum constant.
This fix is related to #2247.