Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectionFormat always multi #2922

Closed
wants to merge 2 commits into from
Closed

Conversation

deripas
Copy link
Contributor

@deripas deripas commented Feb 28, 2019

I using latest version 2.9.2

Linked Issues:

This Issues closed, but problem with collectionFormat not resolve yet!

I use @ApiImplicitParam annotation, like this:

 @ApiImplicitParam(name = "id", paramType = "path", allowMultiple = true, dataType = "long", collectionFormat = "csv")

Swagger result, its generate with collectionFormat: multi.

      parameters:
        - name: id
          in: path
          required: false
          type: array
          items:
            type: integer
            format: int64
          collectionFormat: multi

collectionFormat ignored.

I want to believe in the imminent hot fix 2.9.3
Thank you!

PS this patch based on 2.9.2 tag.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #2922 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2922      +/-   ##
============================================
+ Coverage     94.32%   94.32%   +<.01%     
  Complexity     3239     3239              
============================================
  Files           364      364              
  Lines          8381     8384       +3     
  Branches        619      619              
============================================
+ Hits           7905     7908       +3     
  Misses          318      318              
  Partials        158      158
Impacted Files Coverage Δ Complexity Δ
...ingfox/documentation/builders/ParameterMerger.java 98.18% <100%> (+0.03%) 17 <0> (ø) ⬇️
...ngfox/documentation/builders/ParameterBuilder.java 100% <100%> (ø) 23 <0> (ø) ⬇️
...rs/operation/OperationImplicitParameterReader.java 100% <100%> (ø) 9 <0> (ø) ⬇️

@dilipkrish dilipkrish added the PR label Aug 3, 2019
@dilipkrish dilipkrish added this to the 3.0 milestone Aug 3, 2019
@dilipkrish
Copy link
Member

Rebased and squashed merge commit via 55e7991

@dilipkrish dilipkrish closed this Aug 3, 2019
@dilipkrish
Copy link
Member

Thanks for the PR!

@deripas deripas deleted the 2.9.x branch August 3, 2019 20:38
@appreciated
Copy link

Just as information for someone who is also struggling with this issue:
Using v2.8.0 helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants