Expose the 'showCommonExtensions' configuration available in swagger-ui #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
through springfox UiConfiguration and UiConfigurationBuilder It's available in swagger-ui since v3.14.0 Co-authored-by: Ippei Nawate <saku.ni63@gmail.com> Co-authored-by: Benoit <b.wiart@ubik-ingenierie.com>
Codecov Report
@@ Coverage Diff @@
## master #2973 +/- ##
============================================
- Coverage 94.32% 94.26% -0.06%
- Complexity 3239 3241 +2
============================================
Files 364 364
Lines 8381 8392 +11
Branches 619 619
============================================
+ Hits 7905 7911 +6
- Misses 318 323 +5
Partials 158 158
|
dilipkrish
approved these changes
Aug 3, 2019
This was referenced Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ippei Nawate saku.ni63@gmail.com
Co-authored-by: Benoit b.wiart@ubik-ingenierie.com
What's this PR do/fix?
Expose the 'showCommonExtensions' configuration available in swagger-ui
through springfox UiConfiguration and UiConfigurationBuilder
It's available in swagger-ui since v3.14.0
Are there unit tests? If not how should this be manually tested?
Yes
Any background context you want to provide?
Based on PR #2663 from Ippei Nawate
Rebased for master
Add missing modification of springfox ui js and keep the backward compatibility by adding a new constructor in UiConfiguration
What are the relevant issues?
#2402