Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3075 SpringDataRest Pageable resource with integer paramters #3078

Merged
merged 2 commits into from Aug 8, 2019

Conversation

csegedicsaba
Copy link
Contributor

What's this PR do/fix?

Fixing issue #3075

Are there unit tests? If not how should this be manually tested?

test is updated.

Any background context you want to provide?

Fixing issue #3075

What are the relevant issues?

#3075

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #3078 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3078      +/-   ##
============================================
- Coverage     92.93%   92.91%   -0.03%     
+ Complexity     3513     3512       -1     
============================================
  Files           382      382              
  Lines          9330     9330              
  Branches        768      768              
============================================
- Hits           8671     8669       -2     
- Misses          471      472       +1     
- Partials        188      189       +1
Impacted Files Coverage Δ Complexity Δ
...ntation/spring/data/rest/SpecificationBuilder.java 93.47% <100%> (ø) 15 <0> (ø) ⬇️
...umentation/spring/web/scanners/ApiModelReader.java 94.9% <0%> (-0.57%) 87% <0%> (-1%)

1 similar comment
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #3078 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3078      +/-   ##
============================================
- Coverage     92.93%   92.91%   -0.03%     
+ Complexity     3513     3512       -1     
============================================
  Files           382      382              
  Lines          9330     9330              
  Branches        768      768              
============================================
- Hits           8671     8669       -2     
- Misses          471      472       +1     
- Partials        188      189       +1
Impacted Files Coverage Δ Complexity Δ
...ntation/spring/data/rest/SpecificationBuilder.java 93.47% <100%> (ø) 15 <0> (ø) ⬇️
...umentation/spring/web/scanners/ApiModelReader.java 94.9% <0%> (-0.57%) 87% <0%> (-1%)

@dilipkrish dilipkrish added the PR label Aug 8, 2019
@dilipkrish dilipkrish added this to the 3.0 milestone Aug 8, 2019
@dilipkrish dilipkrish merged commit fb478cf into springfox:master Aug 8, 2019
@dilipkrish
Copy link
Member

Thank you @csegedicsaba!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants