Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringFox 3.0.0-SNAPSHOT boot time is unacceptably slow #3171

Closed
sgri opened this issue Nov 4, 2019 · 6 comments
Closed

SpringFox 3.0.0-SNAPSHOT boot time is unacceptably slow #3171

sgri opened this issue Nov 4, 2019 · 6 comments
Assignees
Milestone

Comments

@sgri
Copy link

sgri commented Nov 4, 2019

We have a web app with 200 REST functions, Spring Fox initialization phase is from 3 to 5 minutes.
The bottleneck is springfox.documentation.spring.web.scanners.ApiModelReader#mergeModelBranch which merges models recursively.

@sgri sgri changed the title Spring Fox 3 boot time is unacceptably slow SpringFox 3.0.0-SNAPSHOT boot time is unacceptably slow Nov 4, 2019
@MaksimOrlov MaksimOrlov self-assigned this Feb 5, 2020
@MaksimOrlov MaksimOrlov added this to the 3.0 milestone Feb 5, 2020
@MaksimOrlov
Copy link
Member

Good evening, @sgri

Could you provide some kind of test repository, so I can find the reason, that makes merging of models slow.

@MaksimOrlov
Copy link
Member

@sgri, could you, please, try latest SNAPSHOT version? There were some PR's with fixes. Does it still work slow with you project?

@dilipkrish
Copy link
Member

@sgri I believe @MaksimOrlov has addressed the performance issues and made it much faster. Closing this issue for now as fixed. Please report back if it isn't

@sgri
Copy link
Author

sgri commented Aug 8, 2020

@sgri, could you, please, try latest SNAPSHOT version?
Unfortunately I could not verify because the latest version 3.0.1-SNAPSHOT is built with java 11.0.7. We still use version 1.8 in production, and when compiling the source code with java 1.8 I get
"startup failed:
/home/sgr/Work/springfox-original/springfox-spring-webmvc/build/classes/groovy/test/springfox/documentation/spring/web/readers/MixedMultipartRequestParameterBuilderSpec$_expectedModel_closure8$_closure24$_closure25$_closure30$_closure33$_closure36$_closure37$_closure38.class (File name too long)"

@sgri
Copy link
Author

sgri commented Aug 8, 2020

Eventually I could launch my application with version 3.0.1-SNAPSHOT, but immediately got a new bug #3482 which blocks testing.

@dilipkrish
Copy link
Member

@sgri while its built with java 11, it still compiles down to java 8. Looking @ your bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants