Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of merging algorithm. #3298

Merged
merged 4 commits into from May 3, 2020
Merged

Conversation

MaksimOrlov
Copy link
Member

@dilipkrish , I added few unit tests, one integration test, fixed one bug, and made some performance enhancement.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #3298 into master will increase coverage by 0.07%.
The diff coverage is 99.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3298      +/-   ##
============================================
+ Coverage     92.89%   92.97%   +0.07%     
- Complexity     3525     3542      +17     
============================================
  Files           382      382              
  Lines          9358     9389      +31     
  Branches        776      760      -16     
============================================
+ Hits           8693     8729      +36     
+ Misses          476      468       -8     
- Partials        189      192       +3     
Impacted Files Coverage Δ Complexity Δ
...umentation/spring/web/scanners/ApiModelReader.java 95.82% <98.95%> (+0.64%) 102.00 <74.00> (+13.00)
...x/documentation/schema/ModelReferenceProvider.java 97.43% <100.00%> (ø) 15.00 <0.00> (ø)
.../documentation/schema/TypeNameIndexingAdapter.java 58.33% <100.00%> (+3.78%) 9.00 <1.00> (ø)
...ocumentation/spi/schema/contexts/ModelContext.java 87.23% <100.00%> (+0.56%) 32.00 <1.00> (ø)
...umentation/spring/web/scanners/MergingContext.java 100.00% <100.00%> (+4.65%) 20.00 <10.00> (+3.00)
...ation/spring/web/scanners/ComparisonCondition.java 62.50% <0.00%> (+6.25%) 6.00% <0.00%> (+1.00%)

@dilipkrish dilipkrish added the PR label May 3, 2020
@dilipkrish dilipkrish added this to the 3.0 milestone May 3, 2020
@dilipkrish dilipkrish merged commit 4c181b6 into master May 3, 2020
@dilipkrish
Copy link
Member

Thank @MaksimOrlov 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants