Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding socketserver to the default ignore list #502

Open
mikix opened this issue Apr 21, 2023 · 0 comments
Open

Consider adding socketserver to the default ignore list #502

mikix opened this issue Apr 21, 2023 · 0 comments

Comments

@mikix
Copy link

mikix commented Apr 21, 2023

(I'm talking about the standard library's socketserver.py module.)

In BaseServer.handle_request(), it uses time() to check for timeouts. If you are running a simple test/mock server as part of your tests, a call to handle incoming requests won't time out when freezegun has frozen time.

I'm not sure if there would be other bad side effects to adding this module. But there's at least the above bug if it's not ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant