Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Code] Support for oracle_sql language files #728

Open
FilipeMestreLS opened this issue Mar 22, 2024 · 3 comments
Open

[VS Code] Support for oracle_sql language files #728

FilipeMestreLS opened this issue Mar 22, 2024 · 3 comments
Labels

Comments

@FilipeMestreLS
Copy link

FilipeMestreLS commented Mar 22, 2024

Currently the VS Code extension only works with "sql" language files and i'd appreciate if it could also work with "oracle_sql" language files, the default for PL/SQL.
Is this possible?

@nene
Copy link
Collaborator

nene commented Mar 24, 2024

I'm not fully sure I understand this issue. What makes these PL/SQL files not classified as SQL files?

Could you please describe how one could reproduce the problem you're having in VSCode.

I'm not really well-versed in VSCode extension development. I am the one maintaining this extension, as there isn't anybody else to do it though. Plus I don't have any experience with Oracle.

@FilipeMestreLS
Copy link
Author

FilipeMestreLS commented Mar 25, 2024

I've been using the "Oracle SQL Developer Extension for VSCode" available in the extension store and it creates a new language in VS Code called "oracle_sql".

image

So by installing this extension and switching the language mode from "sql" to "oracle_sql", this formatter stops working as its not programmed to work with this language.

If i try to force it in the settings to use this formatter as default, by adding this setting in VS Code user settings.json:
"[oracle_sql]": {
"editor.defaultFormatter": "ReneSaarsoo.sql-formatter-vsc"
}

I get the following error:
image

I'm not very knowledgeable about VS Code extensions but my guess is that it is not configured to work with files in the "oracle_sql" VS Code language, just "sql".

@nene
Copy link
Collaborator

nene commented Mar 25, 2024

Thanks for the clarification. There's more of a hope now that I'll manage to do something about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants