-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] DBHub.io icon goes to users' home, not website index page #200
Comments
Aah, just thought .. is this going to get changed anyway as part of the React overhaul? |
Most of that should be do-able, and sound like a good idea.
Yep. Just made that change in local development code, and am running it through our Cypress tests now.
Not sure what you're referring to here. Um, explain a bit more so I get it? 😄
We should leave the [home] link there at least for now. We probably need to at least let people know of the change rather than just removing a link they might be expecting to work.
No worries, added that to the change being tested now.
Yep, that's a good idea too. It won't be tonight to implement though, as I'm finally starting to get really tired. I'm going to push the current header change to GitHub, deploy it to production, then get some sleep shortly afterwards. 😄 |
This is as per issue #200, but there are further pieces that still need working on.
Thanks, understood. That's now been done, and deployed to production. Definitely getting sleep now though. 😄 |
Excellent, thanks! |
Re-opening this because we still need to look at the avatar icon item. 😄 |
Looking at the tooltip suggestions, I'm not exactly sure how to implement it. We're using Bootstrap, but we don't seem to be using "React-Bootstrap" so the initial suggestions from some searching around aren't going to work. Hmmm, there is a suggested CSS approach here though: https://www.w3schools.com/css/css_tooltip.asp That'd probably work. Might be better if we wait for @MKleusberg's input though, just in case there's a better way. 😄 |
I'd really try to avoid adding custom CSS wherever possible. The Bootstrap tooltips should work even without React-bootstrap, probably by adding some |
No worries at all, we can look at this more when the AngularJS stuff is gone. 😄 |
When logged in, would it be possible for the top-left link to go to the users' homepage? Once logged in, the website index page is fairly useless.
The 'DBHub.io' wording isn't included in the link .. could this be added? The icon is fairly small, and it's common practice for the word to be in the link.
If the top-left link becomes the users' homepage, the [Home] link top right isn't needed.
If however the top right link is needed, could it be moved left one place, so it's [Home] [Preferences] [Log out] ? I click 'Home' far more than 'Preferences'.
Other tweaks that don't deserve their own issue
ala, github
The text was updated successfully, but these errors were encountered: