Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] DBHub.io icon goes to users' home, not website index page #200

Open
chrisjlocke opened this issue Apr 30, 2023 · 9 comments
Open

Comments

@chrisjlocke
Copy link
Member

chrisjlocke commented Apr 30, 2023

image

When logged in, would it be possible for the top-left link to go to the users' homepage? Once logged in, the website index page is fairly useless.

The 'DBHub.io' wording isn't included in the link .. could this be added? The icon is fairly small, and it's common practice for the word to be in the link.

If the top-left link becomes the users' homepage, the [Home] link top right isn't needed.

If however the top right link is needed, could it be moved left one place, so it's [Home] [Preferences] [Log out] ? I click 'Home' far more than 'Preferences'.

Other tweaks that don't deserve their own issue

  • Could the 'status updates' icon have a tooltip? Its not clear unless you click it what it actually does.
  • The avatar icon seems a bit redundant. Could it be a link where the 'Preferences' and 'Log out' options live? This would declutter the top navbar.

ala, github

image

@chrisjlocke chrisjlocke changed the title [Suggestion] DBHub.io icon goes to users' home, not homepage [Suggestion] DBHub.io icon goes to users' home, not website index page Apr 30, 2023
@chrisjlocke
Copy link
Member Author

Aah, just thought .. is this going to get changed anyway as part of the React overhaul?

@justinclift
Copy link
Member

Most of that should be do-able, and sound like a good idea.

When logged in, would it be possible for the top-left link to go to the users' homepage?

Yep. Just made that change in local development code, and am running it through our Cypress tests now.

The 'DBHub.io' wording isn't included in the link .. could this be added?

Not sure what you're referring to here. Um, explain a bit more so I get it? 😄

If the top-left link becomes the users' homepage, the [Home] link top right isn't needed.

We should leave the [home] link there at least for now. We probably need to at least let people know of the change rather than just removing a link they might be expecting to work.

If however the top right link is needed, could it be moved left one place, so it's [Home] [Preferences] [Log out] ? I click 'Home' far more than 'Preferences'.

No worries, added that to the change being tested now.

The avatar icon seems a bit redundant. Could it be a link where the 'Preferences' and 'Log out' options live?

Yep, that's a good idea too. It won't be tonight to implement though, as I'm finally starting to get really tired. I'm going to push the current header change to GitHub, deploy it to production, then get some sleep shortly afterwards. 😄

justinclift added a commit that referenced this issue Apr 30, 2023
This is as per issue #200, but there are further pieces
that still need working on.
@chrisjlocke
Copy link
Member Author

Not sure what you're referring to here

image

So make the 'DBHub.io' text clickable too. Currently, you can select the text, which isn't really useful.

@justinclift
Copy link
Member

So make the 'DBHub.io' text clickable too.

Thanks, understood. That's now been done, and deployed to production.

Definitely getting sleep now though. 😄

@chrisjlocke
Copy link
Member Author

Excellent, thanks!

@justinclift
Copy link
Member

Re-opening this because we still need to look at the avatar icon item. 😄

@justinclift
Copy link
Member

Looking at the tooltip suggestions, I'm not exactly sure how to implement it. We're using Bootstrap, but we don't seem to be using "React-Bootstrap" so the initial suggestions from some searching around aren't going to work.

Hmmm, there is a suggested CSS approach here though:

https://www.w3schools.com/css/css_tooltip.asp

That'd probably work. Might be better if we wait for @MKleusberg's input though, just in case there's a better way. 😄

@MKleusberg
Copy link
Member

I'd really try to avoid adding custom CSS wherever possible. The Bootstrap tooltips should work even without React-bootstrap, probably by adding some useEffect which calls documeng.getElementById(...).tooltip(options). In the long run I'd like to use React-bootstrap though. We just need to get rid of the AngularJS version of that first. So honestly I'd suggest just waiting for that till then 😄

@justinclift
Copy link
Member

No worries at all, we can look at this more when the AngularJS stuff is gone. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants