Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog/dark-theme-support-in-our-nightly-builds/ #12

Open
utterances-bot opened this issue Jul 3, 2023 · 9 comments
Open

blog/dark-theme-support-in-our-nightly-builds/ #12

utterances-bot opened this issue Jul 3, 2023 · 9 comments

Comments

@utterances-bot
Copy link

Dark theme support in our nightly builds - DB Browser for SQLite

https://sqlitebrowser.org/blog/dark-theme-support-in-our-nightly-builds/

Copy link

ForgeK1 commented Jul 3, 2023

Thank you!!! This dark mode feature for DB Browser is amazing!

Copy link

Love it. Thx

Copy link

Sneffel commented Oct 3, 2023

It's not very good

@chrisjlocke
Copy link
Member

It's not very good

Rather than a not-very-helpful comment, can you suggest ways in which it can be improved? In what ways is it 'not very good' ? If it was black text on a black background, I can agree with you, but I'm not sure on what improvements can be made by a 'not very good'. Should we just scrap it and start again?

@scottfurry
Copy link

@Sneffel, @chrisjlocke - theming and syntax colours should be better addressed when I push the commit for Settings Clean Up (see discussion #3317).

@Sneffel
Copy link

Sneffel commented Oct 12, 2023

In what ways is it 'not very good' ?

The tabs rectangles aren't distinguishable because they don't have any edge around them until hovered.
Same problem with the buttons and selectable lists.
The icons are too small. So much that the ones without any text are incomprehensible without the hover-tooltip.
I don't like the greyish blue.
And these miscellaneous things:
otherstuff

@chrisjlocke
Copy link
Member

chrisjlocke commented Oct 14, 2023

@Sneffel ; What OS are you using, and what version of DB4S are you using? (Which version of the nightly...)
The small icons look wrong, but as you've seen screenshots of the application, I assume you know that.

Copy link

Suggestion: could you add a way to use non-Dark mode (without having to switch the Desktop style)? Would be great! :)

Copy link

Suggestion(s)
https://gyazo.com/103ffb4149f64ed32a85752787e0a03a

  • There's some parts that are still white in the main interface.. they should probs be changed to match the theme.
  • The window's bar up top is still white also.
  • The dark theme should be customisable. e.g. I personally prefer shades of grey instead of blue.

https://gyazo.com/2b7ff61b98e0efbd56ee198551452fc1

  • The "selected" tab color needs to be customisable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants