Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for connecting to mssql #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for connecting to mssql #224

wants to merge 1 commit into from

Conversation

rgl
Copy link

@rgl rgl commented Aug 22, 2020

This fixes #223.

Please be aware that this is currently using a modified version of the denisenkom/go-mssqldb package as explained in #223.

Here's it working:

$ ./certigo connect --ca ~/Projects/sql-server-vagrant/tmp/ca/example-ca-crt.pem --start-tls mssql --name MSSQL 10.2.2.100
** TLS Connection **
Version: TLS 1.2
Cipher Suite: ECDHE_RSA key exchange, AES_256_GCM_SHA384 cipher

** CERTIFICATE 1 **
Valid: 2020-08-17 19:14 UTC to 2025-08-16 19:14 UTC
Subject:
	CN=MSSQL
Issuer:
	CN=Example CA
DNS Names:
	MSSQL
IP Addresses:
	192.168.121.113

Certificate has OCSP extension, but was unable to check status:
	asn1: syntax error: sequence truncated

Found 1 valid certificate chain(s):
[0] CN=MSSQL
	=> CN=Example CA [self-signed]

BTW, that Certificate has OCSP extension is bogus because none of the certificates in the chain have the OCSP extension.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@mcpherrinm
Copy link
Contributor

yeah there's some bug in the OCSP handling right now. That's #192

@mcpherrinm
Copy link
Contributor

I think once your upstream change is merged into upstream, this is suitable for merging. Thanks!

Do you know how much this increases a certigo binary size?

@rgl
Copy link
Author

rgl commented Aug 25, 2020

It increases the binary size by 1392640 B ( ~1.3 MiB).

The actual binary size built with go 1.15 linux (go build -ldflags -s) was 9789440 (vs 8396800 without mssql).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweissbacher mweissbacher Awaiting requested review from mweissbacher

@isemaya-square isemaya-square Awaiting requested review from isemaya-square

@mmontgomery-square mmontgomery-square Awaiting requested review from mmontgomery-square

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for SQL Server
3 participants
@rgl @CLAassistant @mcpherrinm