Add --no-password flag to the request-cert sub command #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fgrosse! Thank you for your pull request, code looks good. However before we can accept your contribution into the project, Square requires an Individual Contributor License Agreement to be signed. Please let me know once you've signed the CLA and I will merge this. Thank you! |
jonathaningram
suggested changes
Sep 13, 2017
| @@ -36,6 +36,7 @@ func NewCertRequestCommand() cli.Command { | |||
| Description: "Create certificate for host, including certificate signing request and key. Must sign the request in order to generate a certificate.", | |||
| Flags: []cli.Flag{ | |||
| cli.StringFlag{"passphrase", "", "Passphrase to encrypt private-key PEM block", ""}, | |||
| cli.BoolFlag{"no-password", "Do not ask for a passowrd to encrypt the private-key PEM block", ""}, | |||
|
No CLA. This isn't the approach I'd prefer; I think it should be an opt-out flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #37 via an opt-in flag.