Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detectAlignCenter in the Text component has performance issues #577

Open
1 task
rgershon opened this issue Feb 2, 2024 · 0 comments
Open
1 task

detectAlignCenter in the Text component has performance issues #577

rgershon opened this issue Feb 2, 2024 · 0 comments
Labels
bug Something isn't working pending triage

Comments

@rgershon
Copy link

rgershon commented Feb 2, 2024

Bug description

The detectAlignCenter function is responsible for a large amount of blocking time due to style re-calculation.
https://github.com/square/maker/blob/master/src/components/Text/src/Text.vue#L219

See the image where this affects 2560 elements.
image

Reproduction

Visit any production site, preferably with a larger catalog and it will appear in the performance tab.

Environment

Production

Addressed by

No response

Can you contribute a fix?

  • I’m interested in opening a pull request for this issue.
@rgershon rgershon added bug Something isn't working pending triage labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending triage
Projects
None yet
Development

No branches or pull requests

1 participant