Moshi kapt deprecation warning always shown?

[G00fY2]

Does the deprecation warning about kapt is always shown, regardless of Moshi already being used with ksp?

moshi/moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/apt/JsonClassCodegenProcessor.kt

Line 73 in 491e66b

processingEnv.messager.printMessage(Diagnostic.Kind.WARNING, "Kapt support in Moshi Kotlin Code Gen is deprecated and will be removed in 2.0. Please migrate to KSP. https://github.com/square/moshi#codegen")

[ZacSweers]

If it's being shown, it means Moshi is being loaded into kapt/apt and you should remove it from that configuration.

[ZacSweers]

This is a hilt bug, it's loading all annotation processors for some reason in the :app:hiltJavaCompileDebug task. Looks like it's capturing all KSP and kapt dependencies and passing them on to the JavaCompile task it creates

[G00fY2]

I created google/dagger#4116. Let's see what the dagger team says.

[mkubiczek]

How to suppress this warning when -Werror compiler flag is used?

[G00fY2]

From my perspective the easiest solution would be changing moshis warning messages, as suggested by the hilt team.

Not sure how the Moshi maintainers feel about it? Maybe it's worth creating an issue and/or a PR to address this?

Moshi could change the location where the message is reported such that only if it really needs to do processing then (i.e. in a round) it reports the warning and not when it is loaded. This is up to the Moshi authors to decide if it is possible and still maintains their desired migration to KSP goals.

[ZacSweers]

Hilt is loading KSP dependencies into an APT classpath. Tbh I don't see why annotation processor maintainers need to do something to work around hilt's behavior