Don't use jarjar to strip unused classes. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was stripping required classes that were only needed moved classes. We don't have any unused classes so this is a wasted step anyway.
JakeWharton
added a commit
that referenced
this pull request
Jul 25, 2012
Don't use jarjar to strip unused classes.
mjbenedict
pushed a commit
to mjbenedict/okhttp
that referenced
this pull request
Apr 4, 2017
swankjesse
added a commit
that referenced
this pull request
Oct 5, 2020
This was referenced Apr 7, 2022
Closed
Closed
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was stripping required classes that were only needed
moved classes. We don't have any unused classes so this is
a wasted step anyway.