Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly center debug indicators? #791

Open
rothschild86 opened this issue Dec 10, 2014 · 12 comments · May be fixed by ouattararomuald/picasso#2 or #2043
Open

Possibly center debug indicators? #791

rothschild86 opened this issue Dec 10, 2014 · 12 comments · May be fixed by ouattararomuald/picasso#2 or #2043

Comments

@rothschild86
Copy link

In too many places picasso is used with centerCrop() which makes debug indicators invisible (cropped out). And one more scenario: using RoundedImageView also hides the indicator. Having it in the center would fix these kinds of problems. Just making my case :)

@JakeWharton
Copy link
Member

Debug indicators are not applied to the image. They are drawn in the corner of a custom Drawable whose bounds set where it appears. All bitmap transformation, centerCrop included, have no effect on it.

@rothschild86
Copy link
Author

Makes sense. Yet, when I use centerCrop(), indicators don't show (2.4.0). Code used:

    <ImageView
        android:id="@+id/image"
        android:layout_width="match_parent"
        android:layout_height="match_parent" />
Picasso.setSingletonInstance(new Picasso.Builder(this.getApplicationContext()).indicatorsEnabled(true).build());

Picasso.with(StuffdApp.getAppInstance()).load(url).fit().centerCrop().skipMemoryCache().error(R.drawable.ic_5_content_remove);

@JakeWharton
Copy link
Member

We used to tint the whole image. I think it's a bit extreme. Not sure how I
feel about using the center.

@rothschild86
Copy link
Author

This one was totally my fault. Have a framelayout going on and something else was covering a top strip of an image. Still +1 for a centered indicator :)

@lordcodes
Copy link

+1 (Or at least having option to choose a different location).

We have images that already have something over the corner and those cover up the debug indicators.

@osrl
Copy link

osrl commented Mar 13, 2015

+1

@squeeish
Copy link

A center indicator will be great. Like @andrewlord1990 , I have something covering the top left of my images.

@sathvik87
Copy link

I have the similar problem, If I use an ImageView with circular borders, I do not see indicators. If we can configure the position of the indicators, It will be great.

@graycreate
Copy link

Is there a way to center the indicator?

@squeeish
Copy link

squeeish commented Jul 21, 2017

@ghuiii AFAIK, nope.

@JakeWharton JakeWharton added this to the 3.0 milestone Mar 3, 2018
@JakeWharton
Copy link
Member

PR welcome

@ouattararomuald
Copy link

ouattararomuald commented Nov 25, 2018

@JakeWharton I want to work on this.
I'm planning to add boolean indicatorsCentered so it will be used like this PicassoProvider.get().setIndicatorsCentered(true); or new Picasso.Builder(this).indicatorsCentered(true).

When the indicators are centered we will have a round circle in middle of the image view just like the image below which is the result of my current implementation.

Any suggestion or can I go for it ?

Image of Yaktocat

ouattararomuald added a commit to ouattararomuald/picasso that referenced this issue Nov 28, 2018
ouattararomuald added a commit to ouattararomuald/picasso that referenced this issue Nov 28, 2018
ouattararomuald added a commit to ouattararomuald/picasso that referenced this issue Nov 28, 2018
ouattararomuald added a commit to ouattararomuald/picasso that referenced this issue Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants