Add ProtoReader API for length-delimited stream reads
#2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Dec 12, 2023
Comment on lines
+137
to
+139
| check(state == STATE_TAG || state == STATE_LENGTH_DELIMITED) { | ||
| "Unexpected call to nextDelimited()" | ||
| } |
There was a problem hiding this comment.
It's not clear this is useful. Could eliminate and only have the one function.
There was a problem hiding this comment.
Could we make it clearer by telling which state we're in? I don't mind whether we keep it or not
There was a problem hiding this comment.
The message is the same as other places in this file. I can update them all separately to include the current state.
JakeWharton
force-pushed
the
jw.next-length-delimited.2023-12-12
branch
from
b06b8d0
to
cf6698e
Compare
oldergod
approved these changes
Dec 13, 2023
| @@ -32,4 +32,25 @@ class ProtoReaderTest { | |||
| assertEquals(-1, reader.nextTag()) | |||
| reader.endMessageAndGetUnknownFields(token) | |||
| } | |||
|
|
|||
| @Test fun lengthDelimited() { | |||
| val encoded = "0208020608ffffffff07".decodeHex() | |||
There was a problem hiding this comment.
Suggested change
| val encoded = "0208020608ffffffff07".decodeHex() | |
| // Bytes representing: | |
| // ── 0 ┐ | |
| // ╰- 0 ┐ | |
| // ╰- 1: 2147483647 | |
| val encoded = "0208020608ffffffff07".decodeHex() |
There was a problem hiding this comment.
This is not a single proto. It's two protos prefixed with their varint32-encoded lengths. I'll add a comment.
Comment on lines
+137
to
+139
| check(state == STATE_TAG || state == STATE_LENGTH_DELIMITED) { | ||
| "Unexpected call to nextDelimited()" | ||
| } |
There was a problem hiding this comment.
Could we make it clearer by telling which state we're in? I don't mind whether we keep it or not
JakeWharton
force-pushed
the
jw.next-length-delimited.2023-12-12
branch
from
cf6698e
to
2ea68d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #633