Provide a built in public EmptyWireLoggerFactory class #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
commented
Jan 7, 2024
| @@ -1717,24 +1717,4 @@ class WireRunTest { | |||
| logs.add("unusedExcludesInTarget: $unusedExcludes") | |||
| } | |||
| } | |||
|
|
|||
| class CustomLoggerFactory : WireLogger.Factory { | |||
There was a problem hiding this comment.
This was unused so it was deleted.
dnkoutso
force-pushed
the
expose_built_in_empty_logger
branch
from
fd26ff2
to
b15fec2
Compare
|
sweet, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is no
--quietoption in Wire because it is probably obviated by the usage of--logger_factory_classargument.This PR makes it easy for scripts that use Wire not to have to provide their own JAR for a built in "quiet" mode by exposing an empty logger factory and implementation. This now simply works by adding
"--logger_factory_class=com.squareup.wire.schema.EmptyWireLoggerFactory"when invoking Wire.