Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement equals/hash for Duration and Instant on native and JS #2781

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

oldergod
Copy link
Member

fixes #2724

Copy link
Collaborator

@Egorand Egorand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to share code by e.g. declaring extension functions in the common module and calling them from js and native? There's not a ton of code duplication though, so not a big deal.

@oldergod oldergod force-pushed the bquenaudon.2024-01-16.equalshash branch from 8a84932 to 5b4eb94 Compare January 18, 2024 11:28
@oldergod
Copy link
Member Author

Shared the code!

@Egorand
Copy link
Collaborator

Egorand commented Jan 18, 2024

:sweet-kotlin:

@oldergod oldergod merged commit 7d358da into master Jan 18, 2024
7 checks passed
@oldergod oldergod deleted the bquenaudon.2024-01-16.equalshash branch January 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.squareup.wire.Instant should implement equals()/hashCode()
2 participants