Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add escapeKotlinKeywords parameter to Kotlin target #2785

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Add escapeKotlinKeywords parameter to Kotlin target #2785

merged 5 commits into from
Jan 19, 2024

Conversation

Egorand
Copy link
Collaborator

@Egorand Egorand commented Jan 17, 2024 •
edited

This will require a KotlinPoet release so that we can use the new API.

@Egorand Egorand requested a review from oldergod January 17, 2024 13:03
@Egorand Egorand marked this pull request as draft January 17, 2024 13:03
@oldergod
Copy link
Member

👍 probably need to apiDump

Base automatically changed from egor.240117.kotlin-generator-names to master January 17, 2024 16:33
@Egorand Egorand force-pushed the egor.240117.escape-kotlin-keywords branch from 7ba51c3 to c0cfca3 Compare January 19, 2024 10:54
@Egorand Egorand changed the base branch from master to egor.240119.kotlinpoet-1.16.0 January 19, 2024 10:54
@Egorand Egorand marked this pull request as ready for review January 19, 2024 10:55
oldergod
oldergod approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@oldergod oldergod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from egor.240119.kotlinpoet-1.16.0 to master January 19, 2024 11:29
@Egorand Egorand merged commit c252804 into master Jan 19, 2024
7 checks passed
@Egorand Egorand deleted the egor.240117.escape-kotlin-keywords branch January 19, 2024 12:54
@Egorand Egorand mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldergod oldergod oldergod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Egorand @oldergod