[swift] change unknownFields type to [UInt32: Data] from just Data.
#2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
changed the title
unknownFields type to [UInt32: Data] from just Data.unknownFields type to [UInt32: Data] from just Data.
dnkoutso
commented
Jan 19, 2024
dnkoutso
force-pushed
the
unknown_fields_dict
branch
2 times, most recently
from
f4e2b45
to
33e8a5b
Compare
lickel
reviewed
Jan 19, 2024
wire-runtime-swift/src/main/swift/ProtoCodable/ProtoReader.swift
Outdated
Show resolved
Hide resolved
wire-runtime-swift/src/main/swift/ProtoCodable/ProtoWriter.swift
Outdated
Show resolved
Hide resolved
wire-runtime-swift/src/main/swift/wellknowntypes/Duration.swift
Outdated
Show resolved
Hide resolved
dnkoutso
force-pushed
the
unknown_fields_dict
branch
from
33e8a5b
to
24c554b
Compare
dnkoutso
force-pushed
the
unknown_fields_dict
branch
from
24c554b
to
4a8f08e
Compare
lickel
approved these changes
Jan 19, 2024
swankjesse
approved these changes
Jan 20, 2024
|
Have ya seen how we track unknown fields in Java/Kotlin? We keep a ByteString with the encoded data for everything we couldn’t decode. |
|
I just did a quick check, certainly seems nicer to what we have in Swift right now. Is it more about the immutability, utility and performance to adopt something equivalent in Swift? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the already difficult usability of unknown fields but also prepares for a follow up change to re-do Wire proto extensions for Swift.
This is a breaking change that will ship with 5.x of Wire which is a major version bump anyway.