[swift] Introduce a ProtoExtensible protocol that all messages that have been extended conform to.
#2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lickel
approved these changes
Jan 19, 2024
dnkoutso
force-pushed
the
unknown_fields_dict
branch
from
33e8a5b
to
24c554b
Compare
dnkoutso
force-pushed
the
extensible_protocol
branch
from
57c808b
to
22b62cd
Compare
dnkoutso
force-pushed
the
unknown_fields_dict
branch
from
24c554b
to
4a8f08e
Compare
dnkoutso
force-pushed
the
extensible_protocol
branch
3 times, most recently
from
a1e324e
to
6129012
Compare
lickel
approved these changes
Jan 19, 2024
dnkoutso
force-pushed
the
extensible_protocol
branch
from
6129012
to
f90ebff
Compare
dnkoutso
force-pushed
the
extensible_protocol
branch
from
f90ebff
to
953f4ad
Compare
lickel
approved these changes
Jan 21, 2024
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| public protocol ProtoExtensible { |
There was a problem hiding this comment.
Should probably have some DocC for why this exists 😉
… have been extended conform to.
dnkoutso
force-pushed
the
extensible_protocol
branch
from
953f4ad
to
9069cf1
Compare
oldergod
reviewed
Jan 22, 2024
Comment on lines
+53
to
+54
| val isExtensible: Boolean | ||
| get() = extensionsList.isNotEmpty() |
There was a problem hiding this comment.
What does having extensions make it extensible?
There was a problem hiding this comment.
This is the list of reservations for extending a message, no?
If there are reservations then you can do extend Foo or whatever in proto land.
That's what this is referring to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generally harmless and another tiny step in preparation of a moderate re-design on how Wire proto extensions are generated.